Conversation
ezelkow1
approved these changes
Nov 24, 2025
bryancall
approved these changes
Sep 16, 2026
bryancall
left a comment
bryancall
left a comment
Contributor
There was a problem hiding this comment.
✅ Approving.
The target image exists: docker/ubuntu2404/Dockerfile landed on main in #404, shortly after this PR opened. Still MERGEABLE and CLEAN against current main despite sitting for ten months.
This has been approved and correct since November. Someone should merge it.
One question, not a reason to hold it: ubuntu:26.04 now exists in this repo and clang-analyzer.pipeline already uses it. Is 24.04 deliberately the PR-build baseline, or is the PR build just trailing and worth taking straight to 26.04 in a follow-up?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.